search

KomodoPlatform / komodo-wallet

Komodo Wallet
https://app.komodoplatform.com
GNU General Public License v3.0
241 stars 210 forks source link

[BUG]: 5.6 BETA; Price no showing in wallet #1901

Closed ilienongithub closed 2 years ago

ilienongithub commented 2 years ago

Describe the bug the price of ILN is not showing in your wallet. there were trades done in both the last 10 min and 24 hours. Price should come fron Nomics.

If you go to do a swap on ILN the price is there on the nomics chart.

To Reproduce Steps to reproduce the behavior:

  1. Add asset ILN
  2. Click on any of our ILN coins/tokens
  3. No price

Expected behavior Price should show ILON 22 ILN Price

Tried on windows 10

cipig commented 2 years ago

prices older then 600s (10 minutes) are removed here: https://github.com/KomodoPlatform/atomicDEX-Desktop/blob/dev/src/core/atomicdex/api/komodo_prices/komodo.prices.cpp#L83 (expire_at=600)... only if coin is listed on coinpaprika, prices older then 10 minutes are shown from there as a last resort... but ILN is not on coinpaprika would be nice to increase expire_at, most small cap coins don't have any trades in last 10 minutes anyway

ilienongithub commented 2 years ago

Ok so the problim I am seeing is it taks a min 15min for the price on Nomics to update and as your using Nomics charts it would make sence to allow the time for the price on the chart to be relfected, as it is based on your seetings of 10mins no updated prices/trades will ever show from Nomics. Can you help ?

ilienongithub commented 2 years ago

If the ADEX team could reach out to Nomics to see if they could update the price to every say 5 min this would solve this issue. This is me just thinking out loud. Or if you can increase the 10 min window to longer to allow for trades to show.

tonymorony commented 2 years ago

Thank you for the issue opening!

I'm closing this one as a duplicate of https://github.com/KomodoPlatform/atomicDEX-Desktop/issues/1904

We'll look into this problem during the current sprint