KomodoPlatform / komodo-wallet

Komodo Wallet
https://app.komodoplatform.com
GNU General Public License v3.0
240 stars 208 forks source link

[BUG]: Non removable default coins #2225

Closed damascene closed 1 week ago

damascene commented 1 year ago

I'm using AtomicDEX mobile and I've noticed the addition of new default non removable coin KIP0001

AtomicDEX wallet is simple and brilliant wallet , The development team did a great job. I understand that the team may want to keep KMD as a little advertisement for the project that created the DEX however having BTC and KIP0001 as non removable coins reduce space for mobile user specially and may add confusing in case of KIP0001 as most people are not familiar with it.

I believe AtomicDEX targets the general public and not only Komodo community.

I wouldn't mind having KMD, BTC and maybe one other coins as default coin but what is the ration behind having them to stay in the coin list without an option to remove? I wish the development team consider this decision.

smk762 commented 1 year ago

A minimum of two coins is required in the wallet for certain things to function (e.g. dex orderbook caching etc). we have two variables default coin and secondary default coin which are hardcoded. The coins assigned to these variables are currently hardcoded and varies for whatelabel builds. There are also additional default coins which are added to specific builds, like VOTE2023.

It's my opinion that the original atomicdex (this repo, not the whitelabel variants) should retain KMD as a default coin, both as promotion for the project which built it, and also because future upgrades my include perks for holding KMD.

That said, I think that adding a "favourite coins" config in the settings to add 4 or 5 other coins by default is an enhancement worth exploring. These would need to be some constraints (e.g. tokens would also need to include the parent coin).