KomodoPlatform / komodo-wallet

Komodo Wallet
https://app.komodoplatform.com
239 stars 206 forks source link

[BUG]: (doctest) build issue with glibc 2.34 #2333

Closed DeckerSU closed 1 day ago

DeckerSU commented 1 year ago

Since the SIGSTKSZ is no longer a statically defined variable:

[ 71%] Built target komodo-wallet_autogen
In file included from /home/decker/komodo-wallet-desktop/build/src/CMakeFiles/komodo-wallet_tests.dir/Unity/unity_0_cxx.cxx:13:
In file included from /home/decker/komodo-wallet-desktop/src/tests/atomic.dex.tests.cpp:23:
/home/decker/komodo-wallet-desktop/ci_tools_atomic_dex/vcpkg-repo/installed/x64-linux/include/doctest/doctest.h:4041:33: fatal error: variable length array declaration not allowed at file scope
        static char             altStackMem[4 * SIGSTKSZ];
                                ^           ~~~~~~~~~~~~
[ 97%] Built target komodo-wallet
1 error generated.
gmake[2]: *** [src/CMakeFiles/komodo-wallet_tests.dir/build.make:349: src/CMakeFiles/komodo-wallet_tests.dir/Unity/unity_0_cxx.cxx.o] Error 1

It can be temp. fixed with something like:

sed -i 's/altStackMem\[4 \* SIGSTKSZ\]/altStackMem\[4 \* 8192\]/g' ci_tools_atomic_dex/vcpkg-repo/installed/x64-linux/include/doctest/doctest.h

before build.

But better to update doctest in a project from v2.3.8 to v2.4.8.

smk762 commented 1 year ago

Thanks @DeckerSU If you can confirm v2.4.8 has passed sec review, we can update https://github.com/KomodoPlatform/doctest/ and I'll update the portfile.cmake in this repo to use the newer version in our fork