Upgrade Z coin activation

smk762 commented 1 year ago

ref: https://github.com/KomodoPlatform/komodo-defi-framework/pull/1922 closes: https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/2354

This PR introduces the sync_params feature in the newly released 1.0.7 API. This allows the user to specify which block to begin sync from - previously it was hardcoded as block 1900000 (for ARRR).

After this PR is merged it will use the block height selected by the user in settings, and where the setting does not exist (e.g. for zombie) it will use the checkpoint block from coins_config.json

To test:

From a clean wallet, activate ARRR.
Confirm progress % is sane.
Select an earlier block from the settings, then restart app and try to activate again. The sync block value should appear in logs like "first_sync_block":{"actual":1500000,"is_pre_sapling":false,"requested":1500000}. You dont need to wait for full sync (it takes a long time), just confirm in logs.
From an older wallet, repeat the above steps.

Note: Balance from transactions prior to the sync block will not be visible / included.

borngraced commented 1 year ago

will there be an option to pick a date too? like an interactive date picker. @smk762

smk762 commented 1 year ago

closing in favor of https://github.com/KomodoPlatform/komodo-wallet-desktop/pull/2356

smk762 commented 1 year ago

will there be an option to pick a date too? like an interactive date picker. @smk762

heh, I thought the same, just wasnt sure how long it would take. Turns out, not so long.

KomodoPlatform / komodo-wallet

Upgrade Z coin activation #2355