Closed cipig closed 4 months ago
Not exactly the same, but likely came from same source of error of pricing. For pytomicDEX_makebot I did over past couple of days, I found this error and bot won't run on CHTA/KMD pairs: ERROR simple_market_maker:372] Rates from provider are Unknown - skipping for KMD/CHTA
The error came from here from mm2 code: https://github.com/KomodoPlatform/komodo-defi-framework/blob/main/mm2src/mm2_main/src/lp_ordermatch/simple_market_maker.rs#L41
Most likely, mm2 komodo-defi-framework code base has a rounding assumption that any price below certain smaller value will be truncated to zero.
Hopefully this source code limitation bug can be fixed and allow Cheetahcoin Nengcoin etc smaller coins have a pricing in Komodo wallet. Currently AtomicDEX is thinly traded and most user case is for smaller coins with cheap fees.
the integrated maker bot needs a price source... it uses the URL you passed to it... eg https://prices.komodo.earth/api/v2/tickers ... if CHTA does not have a price there, i expect to see the above error... CHTA has a id for coinpaprika and livecoinwatch defined in https://github.com/KomodoPlatform/coins/tree/master/api_ids ... coinpaprika can't be used though, because CHTA is missing circulating supply info there and as such does not have a market cap... paprika only shows the prices of the top 2500 coins in their free API... without a mcap a coin has no ranking and as such can't be in top 2500... update the supply on paprika, so CHTA has a chance to be in top 2500 coins, then the chance is higher that there will be a price for it
No longer appears to be an issue
that is only because the price of CHTA surpassed 0.00001... everything below is shown as 0
price of BTTC is $0.00000160, CHTA is $0.00000398... both show up as 0...so looks like the app cuts off the last 3 decimals, so it gets the price with 8 decimals from the API, but somewhere in code it's stripped down to 5 decimals.
Komodo Wallet shows a price of 0 (with 8 decimals) for CHTA as coming from livecoinwatch, but the price from our endpoint on https://prices.komodo.earth/api/v2/tickers?expire_at=21600 is 0.000001 (6 decimals):
Interesting is that the price is actually used, else there wouldn't be a "Fiat Balance" value.