KomodoPlatform / komodo-wallet

Komodo Wallet
https://app.komodoplatform.com
239 stars 206 forks source link

Add Maker mode, and order form options for `GoodTillCancelled` / `FillOrKill` #2424

Closed smk762 closed 6 months ago

smk762 commented 6 months ago

Closes https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/956

This PR also includes some changes to the dex pro view layout. All trading operations on both Simple and Pro view should be thoroughly tested for regression.

https://github.com/KomodoPlatform/komodo-wallet-desktop/assets/35845239/f9a436fb-0bc7-4130-bb9a-f43ceaae80ba

Beyond the layout changes, this PR introduces a checkbox in the Confirm Exchange Details modal image

This checkbox is on by default, which is effectively the same as before: When you create an order, if it does not match within 30 seconds, it becomes a maker order and stays on the orderbook.

If the checkbox is unticked, the order id place with the FillOrKill order_type parameter.

This means that if an order is placed which is not matched with an existing order on the orderbook, it will automatically cancel after 30 seconds.

To Test (pro view):

To Test (general):

PART 2 BELOW

smk762 commented 6 months ago

Closes https://github.com/KomodoPlatform/komodo-wallet-desktop/issues/956 (the rest) Added Maker tab for order form to allow users to place maker (setprice) orders.

https://github.com/KomodoPlatform/komodo-wallet-desktop/assets/35845239/06175dfc-b370-4006-b185-fb2c310308dd

To test:

https://github.com/KomodoPlatform/komodo-wallet-desktop/assets/35845239/6e8e29dd-396d-4043-9856-97360021b869

smk762 commented 6 months ago

Thanks! Should be fixed now, I've moved the warnings into the scrollable area image

TheComputerGenie commented 6 months ago

How does one get something that looks like what you're showing rather than this: image