search

KomodoPlatform / komodo-wallet

Komodo Wallet
https://app.komodoplatform.com
239 stars 206 forks source link

[BUG]: "receive" amount of swap does not fit into field #2461

Closed cipig closed 1 day ago

cipig commented 3 months ago

if i click on the order selling ~2501 JASMY-BEP20, the receive amount does not fir into the field: image maybe we can make the field using 2 lines

smk762 commented 2 months ago

Due to horizontal space constraints, Can't really add a new line without something else falling off the page in some cases. Best I can do for now is to reduce the font size of the ticker. Do you think the protocol being included in that part is needed?

cipig commented 2 months ago

Do you think the protocol being included in that part is needed?

No, i don't think it's needed... wasn't that already removed and then re added because of something?

ShantanuSharma9873 commented 2 months ago

Here, the price and sending amount both fit within the field, but I noticed that there's no character limit enforced. Users can enter an unlimited number of digits, which allows the amount to increase indefinitely when more numbers are added. image

cipig commented 2 months ago

I noticed that there's no character limit enforced. Users can enter an unlimited number of digits, which allows the amount to increase indefinitely when more numbers are added.

i don't think we can enforce a limit on volume and price, since there are coins/tokens worth almost nothing (eg look in BTTC-BEP20/KMD orderbook), so volume and price can be pretty big

image