search

KomodoPlatform / komodo

Komodo
https://komodoplatform.com/
Other
119 stars 97 forks source link

THROW_IF_SYNCING incorrectly disabled for what reason? #360

Closed leto closed 4 years ago

leto commented 4 years ago

THROW_IF_SYNCING is an important mitigation against metadata leakage and it was recently disabled in 2 places and forgot to be disabled in the 3rd place.

Why was this done without asking for feedback on the privacy/security implications?

ca333 commented 4 years ago

Thank you for the information @leto - i created https://github.com/KomodoPlatform/komodo/tree/privacy for privacy feature utilising SmartChains with https://github.com/KomodoPlatform/komodo/commit/1559b80bd54ebcf2d017ae285d444af2e1814781.

This change was added cuz detecting the sync state wasn't/isn't reliable (on our todo) - and when pushing it to our dev branch i kept z_mergetoaddress 'safe' as we were using the same dev repo/branch for few merge-OPs - 'sorted' this with https://github.com/KomodoPlatform/komodo/commit/4db55911612c772f6a124c1898a8d35452cf1346

leto commented 4 years ago

@ca333 I will assume you and Pirate understand the privacy implications of this and only concern myself with Hush