search

KomodoPlatform / komodo

Komodo
https://komodoplatform.com/en/
Other
119 stars 98 forks source link

[Feature Request] Add support of domain names in "-addnode=" komodod parameters #377

Open satindergrewal opened 4 years ago

satindergrewal commented 4 years ago

Just had a thought if komodod supports domain name with the parameter -addnode=, but I think it does not.

It would be great to add the root DNS (i.e. example.com) and also any subdomain (i.e. node.example.com, joe.node.example.com, bob.node.example.com) support to komodod if it already doesn't support.

Having this feature will allow using Dynamic DNS as a -addnode= parameter value, which can use dynamically changing IP for Antara Smartchains.

tonymorony commented 4 years ago

have to test how it works now (as I remember when I've tested it ~year ago it worked with domain in addnode param just fine), but in any case you can determine domain resolving IP on startup by OS tools, for example: https://github.com/KomodoPlatform/komodo/blob/master/src/assetchains#L7

TheComputerGenie commented 4 years ago

afaik, both -connect and -addnode should already do this. I'm certain komodo-cli does; do they use different code paths?