search

Komorebi-Fork / komorebi

A beautiful and customisable wallpaper manager for Linux
GNU General Public License v3.0
279 stars 19 forks source link

[Bug] Video wallpapers not visible without a thumbnail image #15

Open Kangie opened 4 years ago

Kangie commented 4 years ago

If the wallpaper creator is not given a thumbnail image for a video wallpaper, it will not appear in the wallpaper grid.

This is because the code that enumerates wallpapers looks for 'wallpaper.jpg'. See: here.

I see two solutions:

  1. Modify the code so that it looks for a video file as well, or so that it only looks for the config.
  2. Provide / generate a thumbnail when one isn't provided.

I've used ffmpeg to do it to work around this issue, but I'm sure that there's a way to do it using gstreamer. ffmpeg -i MOVIE.mp4 -r 0.0033 -vf scale=-1:120 -vcodec png capture-%002d.png

rsubtil commented 4 years ago

I vote for option 2, as having to specifiy a thumbnail for a video is kinda dumb.

As to how to do it, there's probably an easier way to do this, but here's my idea: we could "spawn" a stream that is paused and make it seekable, and then grab the video sink to get the picture. We then might be able to use a combination of this and this to save it to disk.

Arham4 commented 4 years ago

Oh my, I remember how much this annoyed me when I first used Komorebi. I was always meaning to work on option 2.