Kompakkt / Repo

Repository for Kompakkt, the Web Based multimodal 3D Viewer and 3D Annotation System.
https://kompakkt.de
GNU Affero General Public License v3.0
12 stars 2 forks source link

UI Design sync between Kompakkt and Semantic Kompakkt #40

Open lozanaross opened 4 months ago

lozanaross commented 4 months ago

@Grizzly127 to coordinate work with @vmalieske and @NadNo12 that ensures Kompakkt and Semantic Kompakkt use nearly same UI design apart from Wikibase-specific components.

Use existing Google doc and Figma files to track the pages that need UI updates.

Grizzly127 commented 4 months ago

Updates for the Explore page:

this is the Explore page for kompakkt:

Bildschirmfoto 2024-05-15 um 15 19 31

this for semantic-kompakkt right now:

Bildschirmfoto 2024-05-15 um 15 19 39

@vmalieske @NadNo12

lozanaross commented 4 months ago

Hi Senya, I think this is a good start, but I think we should have the bullet list split in two groups - what needs changing in Kompakkt and what needs changing in Semantic Kompakkt. Maybe the SK bullets are only recorded in Gitlab, and here we only record what needs to change in Kompakkt.

I also found this doc: https://docs.google.com/document/d/1LpYLtyvN7L9SqWqyrBQ2BbvKze5U57b1iUtAPg3_0ZM/edit should we start there and go page by page? I think it's good idea to start with Explore, but then maybe check the google doc and assign pages from that to individual colleagues to tackle, so we don't need to recreate evertything in comments here, or is the google doc already a bit outdated?

vmalieske commented 4 months ago

When the user is not logged in, there are buttons for Login and Registration. Should these also be removed (since Login and Registration are already in the Navbar)?

vmalieske commented 4 months ago

This points are done:

Changes are within the pull request with the angular-material-upgrade.

Grizzly127 commented 4 months ago

Hi Senya, I think this is a good start, but I think we should have the bullet list split in two groups - what needs changing in Kompakkt and what needs changing in Semantic Kompakkt. Maybe the SK bullets are only recorded in Gitlab, and here we only record what needs to change in Kompakkt.

okay, yes I can do that. For me it's easier to have both next to each other to synchronize it best, but I can split it afterwards, so it's easier for @vmalieske to work on it.

I also found this doc: https://docs.google.com/document/d/1LpYLtyvN7L9SqWqyrBQ2BbvKze5U57b1iUtAPg3_0ZM/edit should we start there and go page by page? I think it's good idea to start with Explore, but then maybe check the google doc and assign pages from that to individual colleagues to tackle, so we don't need to recreate everything in comments here, or is the google doc already a bit outdated?

Yes, unfortunately it is outdated now. I can still use it as an orientation and to know which pages to look at, but most of it is outdated and was already somehow updated. At least for the Repo, I didn't look into the viewer yet. But that also means, that there is a lot of work done already.

Grizzly127 commented 4 months ago
  • add the New Object and for now for kompakkt also the New Collections button to the navigation bar

When the user is not logged in, there are buttons for Login and Registration. Should these also be removed (since Login and Registration are already in the Navbar)?

Yes, @vmalieske I would remove them, you're right we already have it in the Navbar.

Grizzly127 commented 4 months ago

object options kompakkt

current options:

Bildschirmfoto 2023-04-04 um 14 55 06

@lozanaross @vmalieske

Grizzly127 commented 4 months ago

Login and Register at the start page of kompakkt With the new Navigationbar the Login and Register options and the history button here on the start page of kompakkt should also be removed

Bildschirmfoto 2023-04-06 um 09 08 45

@vmalieske

Grizzly127 commented 4 months ago

Login and Register

Register

Bildschirmfoto 2024-05-27 um 13 48 02

Login

Bildschirmfoto 2024-05-27 um 13 50 15

Login is mostly synchronized, but the "Cancel" button here is black. I think we should use the same on like in the Registration. Also use pink as the accent color: E91E63.

@lozanaross Question: I'm not sure with the colors anymore. Did we say we are using pink here and orange for semantic kompakkt or did we say we are using the same color for both?

@vmalieske

lozanaross commented 4 months ago

Hi Senya, I think this is a good start, but I think we should have the bullet list split in two groups - what needs changing in Kompakkt and what needs changing in Semantic Kompakkt. Maybe the SK bullets are only recorded in Gitlab, and here we only record what needs to change in Kompakkt.

okay, yes I can do that. For me it's easier to have both next to each other to synchronize it best, but I can split it afterwards, so it's easier for @vmalieske to work on it.

This will work - thanks!

I also found this doc: https://docs.google.com/document/d/1LpYLtyvN7L9SqWqyrBQ2BbvKze5U57b1iUtAPg3_0ZM/edit should we start there and go page by page? I think it's good idea to start with Explore, but then maybe check the google doc and assign pages from that to individual colleagues to tackle, so we don't need to recreate everything in comments here, or is the google doc already a bit outdated?

Yes, unfortunately it is outdated now. I can still use it as an orientation and to know which pages to look at, but most of it is outdated and was already somehow updated. At least for the Repo, I didn't look into the viewer yet. But that also means, that there is a lot of work done already.

OK, that's good news then.

lozanaross commented 4 months ago

@lozanaross Question: I'm not sure with the colors anymore. Did we say we are using pink here and orange for semantic kompakkt or did we say we are using the same color for both?

I think we agreed that we'll use same color for both (so pink) when it comes to functional elements. Maybe we can discuss further how to use orange in SK in a way that only concerns the Wikibase metadata that doesn't exist in Kompakkt anyway. But that's a separate task.

@HeyItsBATMAN can you assign this whole issue to @vmalieske so she gets notifications without need to be tagged in every comment.

Grizzly127 commented 3 months ago

object view option bar

Bildschirmfoto 2023-04-04 um 15 20 00

new:

Bildschirmfoto 2024-06-06 um 17 49 21
vmalieske commented 3 months ago

To point 3 (Annotate-Button): How should the disabled button look like? At the moment, it is just grey: image

And should there be a tooltip for that button? At the moment, there is a tooltip when disabled (You are not allowed to annotate right now) and no tooltip when enabled.

Grizzly127 commented 3 months ago

Upload process

Change the color of the "Reset" button here in kompakkt to the pink color And in previous versions sometimes there was a wrong font used (Helvetica Neue I think), I am not sure about the current font, it is not clear to me right now. But make sure for the buttons and for the text that Open Sans is used.

Bildschirmfoto 2024-06-12 um 15 10 07

in kompakkt you can also see the annotation icon here, since you can't annotate here, we should remove it

Bildschirmfoto 2024-06-12 um 15 23 22

The matadata formula looks very different, but I think this also belongs to the discussion of #42 first.

something is wrong here at kompakkt at the Finlize site for the settings:

Bildschirmfoto 2024-06-12 um 15 32 13
lozanaross commented 3 months ago

Thanks for summarising the next set of issues here @Grizzly127

Regarding your question:

I'm not sure about this icon: image , it says "Use this object in a collection", I think it means to use it in an already existing collection. Is that option also possible in the "New Collection" button or can we integrate that there or should we keep the icon here? @lozanaross

We had a solution with a single icon that could solve both adding to an existing and to a new collection when we designed the new Explore / institutional page. Perhaps you can find that in the Figma file and paste here (I think the solution was in the pop up that opens when clicking the "[+]" icon). I think we should use that same icon here and position the collection-related icons as per your mockups:

Screenshot 2024-06-17 at 16 34 22

Also I just noticed I don't think we have an issue dedicated to the institutional page, only to its mobile version, maybe worth making.

lozanaross commented 3 months ago

To point 3 (Annotate-Button): How should the disabled button look like? At the moment, it is just grey: image

And should there be a tooltip for that button? At the moment, there is a tooltip when disabled (You are not allowed to annotate right now) and no tooltip when enabled.

Thanks for the question @vmalieske - I think we don't need a tooltip when the button is active, it's self-explanatory. But I wonder why would we show it disabled. I think if the user doesn't have privileges to edit an object, the button should simply not be there? And it could appear when the user does have the rights.

Or what do you think @HeyItsBATMAN @ZetOE @Grizzly127

Alternatively, if the annotate button is showed grey, we should align the tooltip across both versions - currently in SK, it says: "Only the object owner is allowed to annotate this object." I don't think this is great, but neither is the Kompakkt version, we need some text to indicate that you can't annotate right now, but maybe you could if you add to collection. So perhaps we change the text in both versions to: "Add object to collection to be able to annotate"

HeyItsBATMAN commented 3 months ago

I don't have a strong opinion on this. I guess it can be removed if the user is not able to annotate it, but theoretically, a user can always annotate an object that is part of a collection, and any public object can be added to a collection, and then be annotated.

So I think the "Annotate"-button could be removed going forward, in favor of guiding the user to creating annotations inside of collections?

The only case where it's useful is if the uploader of an object needs to modify the default annotations, right?

Grizzly127 commented 3 months ago

We had a solution with a single icon that could solve both adding to an existing and to a new collection when we designed the new Explore / institutional page. Perhaps you can find that in the Figma file and paste here (I think the solution was in the pop up that opens when clicking the "[+]" icon). I think we should use that same icon here and position the collection-related icons as per your mockups:

Good idea, then we add this icon here and the user gets two options on adding an object to a collection in kompakkt:

Bildschirmfoto 2024-06-18 um 12 41 32 Bildschirmfoto 2024-06-18 um 12 42 06
vmalieske commented 3 months ago

@HeyItsBATMAN Could you have a look at the last commit? Just the code of actionbar. I had to rewrite the metadata-functionality (switch the icons from detail-page to actionbar) and want to be sure that it's okay.

vmalieske commented 3 months ago

We had a solution with a single icon that could solve both adding to an existing and to a new collection when we designed the new Explore / institutional page. Perhaps you can find that in the Figma file and paste here (I think the solution was in the pop up that opens when clicking the "[+]" icon). I think we should use that same icon here and position the collection-related icons as per your mockups:

Good idea, then we add this icon here and the user gets two options on adding an object to a collection in kompakkt:

And then another small option-window for the existing collections?

lozanaross commented 3 months ago

Good idea, then we add this icon here and the user gets two options on adding an object to a collection in kompakkt:

@Grizzly127 do you think we should move some buttons to the left? now all buttons are bundled on the right and maybe it's becoming a bit heavy (visually) how about if we move Publish & Annotate to the left (and then these buttons are not visible anyway when another user (not the object owner) opens an object.

And maybe the [+] button is after the edit button, because then Add, Embed, etc, are always visible, whereas Edit disappears when you're not logged in, or when you're not the owner.

lozanaross commented 3 months ago

I don't have a strong opinion on this. I guess it can be removed if the user is not able to annotate it, but theoretically, a user can always annotate an object that is part of a collection, and any public object can be added to a collection, and then be annotated.

So I think the "Annotate"-button could be removed going forward, in favor of guiding the user to creating annotations inside of collections?

Maybe we can keep the Annotate button when an object is already inside a collection - @Grizzly127 do you want to work on a mockup of how this would look? it could just be the same button, but maybe there's also a special prompt once a user adds something in a collection in order to highlight the possibility for annotation a bit more.

The only case where it's useful is if the uploader of an object needs to modify the default annotations, right?

Yes, I think the owner / uploader of an object should always see the Annotate button.

vmalieske commented 3 months ago

We had a solution with a single icon that could solve both adding to an existing and to a new collection when we designed the new Explore / institutional page. Perhaps you can find that in the Figma file and paste here (I think the solution was in the pop up that opens when clicking the "[+]" icon). I think we should use that same icon here and position the collection-related icons as per your mockups:

Good idea, then we add this icon here and the user gets two options on adding an object to a collection in kompakkt:

Bildschirmfoto 2024-06-18 um 12 41 32 Bildschirmfoto 2024-06-18 um 12 42 06

That could be looked like this: image

vmalieske commented 3 months ago

All design changes up to this point are in the pull request (forgot to mention the issue here). Except the Annotate-issue, there I will wait for the mockup, right?

Grizzly127 commented 3 months ago

@Grizzly127 do you think we should move some buttons to the left? now all buttons are bundled on the right and maybe it's becoming a bit heavy (visually) how about if we move Publish & Annotate to the left (and then these buttons are not visible anyway when another user (not the object owner) opens an object.

And maybe the [+] button is after the edit button, because then Add, Embed, etc, are always visible, whereas Edit disappears when you're not logged in, or when you're not the owner.

Yes, we can change the edit and the [+] button, that makes sense. This is how it would look like to have the Publish and annotate on the left , but I think for me it was also okay to have all the functions in one place on the right.

Bildschirmfoto 2024-06-21 um 17 07 16

@lozanaross

Grizzly127 commented 3 months ago

That could be looked like this: image

For me this would be good for now to see the names of the collection where you can add it too, yes!:) I would just say the option is called: "add to existing collection"

@vmalieske @lozanaross

Grizzly127 commented 3 months ago

I don't have a strong opinion on this. I guess it can be removed if the user is not able to annotate it, but theoretically, a user can always annotate an object that is part of a collection, and any public object can be added to a collection, and then be annotated. So I think the "Annotate"-button could be removed going forward, in favor of guiding the user to creating annotations inside of collections?

Maybe we can keep the Annotate button when an object is already inside a collection - @Grizzly127 do you want to work on a mockup of how this would look? it could just be the same button, but maybe there's also a special prompt once a user adds something in a collection in order to highlight the possibility for annotation a bit more.

The only case where it's useful is if the uploader of an object needs to modify the default annotations, right?

Yes, I think the owner / uploader of an object should always see the Annotate button.

I don't know exactly what you mean here. Should I do a mock-up without the Annotate-button or a different kind of Annotate-button? Can you explain this issue again, please?

@HeyItsBATMAN @lozanaross

lozanaross commented 2 months ago

Yes, we can change the edit and the [+] button, that makes sense. This is how it would look like to have the Publish and annotate on the left , but I think for me it was also okay to have all the functions in one place on the right.

Thanks @Grizzly127 - agreed - Publish + Annotate buttons look not too bad on the left, but they can also stay in one place on the right. Please proceed with whichever version you prefer.

lozanaross commented 2 months ago

For me this would be good for now to see the names of the collection where you can add it too, yes!:) I would just say the option is called: "add to existing collection"

@Grizzly127 @vmalieske Yes, I also agree

lozanaross commented 2 months ago

I don't know exactly what you mean here. Should I do a mock-up without the Annotate-button or a different kind of Annotate-button? Can you explain this issue again, please?

@vmalieske @Grizzly127 @HeyItsBATMAN

As discussed today, let's keep Annotate button always visible for owners of objects and when the object is already inside a collection. When the object is not in a collection and the user is not the owner, they should see a grey button with a tooltip over the button that says: "To be able to annotate, add this object to one of your collections."

Grizzly127 commented 2 months ago

Thanks @Grizzly127 - agreed - Publish + Annotate buttons look not too bad on the left, but they can also stay in one place on the right. Please proceed with whichever version you prefer.

Since the amount of buttons on the right, change sometimes when you are able to edit or not. Maybe it's better to put the Publish and Annotate button on the left

Bildschirmfoto 2024-07-23 um 12 17 14

As discussed today, let's keep Annotate button always visible for owners of objects and when the object is already inside a collection. When the object is not in a collection and the user is not the owner, they should see a grey button with a tooltip over the button that says: "To be able to annotate, add this object to one of your collections."

Bildschirmfoto 2024-07-23 um 12 18 31

I'm not sure about the size of the tooltip, what do you think?

Bildschirmfoto 2024-07-23 um 12 22 12

@vmalieske @lozanaross

Grizzly127 commented 2 months ago

Visibility Settings

These are the current settings for the visibility of an object in kompakkt

Bildschirmfoto 2024-07-23 um 12 33 12 Bildschirmfoto 2024-07-23 um 12 45 49

In semantic kompakkt only the buttons need to be changed, then it is already the same. What do you think about making it look cleaner already? For example:

Bildschirmfoto 2024-07-23 um 12 51 31

@vmalieske @lozanaross