Kompakkt / Viewer

Kompakkt - the web based 3D viewer and 3D annotation system.
https://kompakkt.de
GNU Affero General Public License v3.0
15 stars 2 forks source link

Viewer design alignment with semantic kompakkt #53

Open Grizzly127 opened 1 month ago

Grizzly127 commented 1 month ago

Options in the viewer for the object page

in kompakkt this options are available:

Bildschirmfoto 2024-07-24 um 12 40 15

in semantic kompakkt this options are available:

Bildschirmfoto 2024-07-24 um 12 39 36

Which options are still relevant? Which ones should be used here? @lozanaross @HeyItsBATMAN

HeyItsBATMAN commented 1 month ago
Grizzly127 commented 1 month ago

Alright, then the features for kompakkt can stay the same. Except for eventually removing the language feature. I'll write the adaptions for semantic kompakkt in Gitlab.

lozanaross commented 1 month ago

Thanks @HeyItsBATMAN and @Grizzly127, yes, language should be in a plugin for SK, since we don't yet have option to switch to German (which would be relevant to us), we should not include it for now.

Grizzly127 commented 1 month ago

sidebar design

Kai and me worked on the sidebar and Kai already implemented it, so it is basically ready. Do you have any feedback?

here is a snippet of how it looked before:

Bildschirmfoto 2024-08-01 um 18 00 36

after: maybe it's better to see in Figma, since it looks small here

Bildschirmfoto 2024-08-01 um 18 03 10

light mode will follow

@lozanaross @HeyItsBATMAN

lozanaross commented 1 month ago

@Grizzly127 Sidebar design looks good, i just made some recommendations in Figma mostly connected to text changes.

Grizzly127 commented 1 month ago

@Grizzly127 Sidebar design looks good, i just made some recommendations in Figma mostly connected to text changes.

I implemented the text changes:

Bildschirmfoto 2024-08-02 um 13 45 12

The darkmode sidebar has slightly grey boxes to divide the parts better, instead of a line. It looked better than the line, I think. That's why the light mode also has the boxes and that's where the boxes for the annotation window come from. I can make another mock-up without the boxes.

This is the light mode so far:

Bildschirmfoto 2024-08-02 um 13 45 22

@lozanaross

lozanaross commented 1 month ago

@Grizzly127 OK, I see - it was less noticeable in the dark mode and now I am not sure, we don't use these boxes within boxes anywhere else and it introduces a lot of extra padding - the sidebar is already narrow and within this sidebar we're adding another layer of padding that makes everything narrower. But mostly, if you look around the entire UI to date (in the Figma file) - we use grey input boxes within dialogs (eg see login or Register) and we sometimes use dividing lines, or something like lines, in places like the Upload wizard, but also in the display of metadata on the side of the viewer window, etc. So i think we should stick more to the existing UI, otherwise we'll have to revise a lot more sections to then use these rounded boxes. And in the case of the sidebar here, I don't think we even need dividing lines because you introduced the little section headings with the arrow symbol we also use in the metadata wizard. I would suggest you mock this up as a single block / sidebar without dividing lines and only using typography and padding to differentiate the sections.

Grizzly127 commented 1 month ago

Here is the design without the boxes and without double background settings:

darkmode:

Bildschirmfoto 2024-08-05 um 15 11 30

lightmode:

Bildschirmfoto 2024-08-05 um 15 11 41

@lozanaross

lozanaross commented 1 month ago

Thanks @Grizzly127 I think this looks quite clear. Only small suggestion to keep things more consistent would be to make the input fields (x, y, z axis) in dark mode also a shade of grey different from the background (like they are in light mode).

Grizzly127 commented 1 month ago

Thanks @Grizzly127 I think this looks quite clear. Only small suggestion to keep things more consistent would be to make the input fields (x, y, z axis) in dark mode also a shade of grey different from the background (like they are in light mode).

alright, added grey to the input fields

Bildschirmfoto 2024-08-06 um 16 37 35
Grizzly127 commented 4 days ago

Corrections viewer

Some small corrections or bugs that occurred to us.

@HeyItsBATMAN