search

KomputeProject / kompute

General purpose GPU compute framework built on Vulkan to support 1000s of cross vendor graphics cards (AMD, Qualcomm, NVIDIA & friends). Blazing fast, mobile-enabled, asynchronous and optimized for advanced GPU data processing usecases. Backed by the Linux Foundation.
http://kompute.cc/
Apache License 2.0
1.88k stars 145 forks source link

Fix cmake installation #334

Closed ToKiNoBug closed 9 months ago

ToKiNoBug commented 9 months ago

Issue #324 mentioned that installation fails on many platforms because komputeConfigVersion.cmake is missing. I tried and found out that this issue happens on may platforms, (for example, on Windows11 with msvc and clang16, and on archlinux with gcc13 and clang16).

So I add some lines to generate it, and I believe this will fix #324 .

ToKiNoBug commented 9 months ago

Commit 8ea8cd226df82716f57f65651bcb24b9e12e63f5 aims to fix header installation. An extra install command in src/include/CMakeLists.txt is removed because it requires non-existing directory src/include/logger, but logger headers are in src/include/kompute/logger. This line is redundant because logger headers are already installed with line 30.

install(DIRECTORY kompute DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
axsaucedo commented 9 months ago

Thank you for the contribution, added a minor comment but overall looks good, if you can update (+ update DCO) should be good to merge

ToKiNoBug commented 9 months ago

Thank you for the contribution, added a minor comment but overall looks good, if you can update (+ update DCO) should be good to merge

Thanks for your appearciation, I will work on this.

ToKiNoBug commented 9 months ago

I will start a new pr with verified commits.