search

KomputeProject / kompute

General purpose GPU compute framework built on Vulkan to support 1000s of cross vendor graphics cards (AMD, Qualcomm, NVIDIA & friends). Blazing fast, mobile-enabled, asynchronous and optimized for advanced GPU data processing usecases. Backed by the Linux Foundation.
http://kompute.cc/
Apache License 2.0
1.97k stars 151 forks source link

CMake build bug when installing with KOMPUTE_OPT_USE_BUILT_IN_FMT off #359

Closed SimLeek closed 2 months ago

SimLeek commented 7 months ago

Easy to work around. I just have to do this:

find_package(fmt REQUIRED)
find_package(kompute REQUIRED)

instead of:

find_package(kompute REQUIRED)

System: Arch Linux

Could be confusing if you don't know the workaround. Since it gives an error in the kompute cmake files:

[cmake] CMake Error at /usr/local/lib/cmake/kompute/komputeTargets.cmake:69 (set_target_properties):
[cmake]   The link interface of target "kompute::kp_logger" contains:
[cmake] 
[cmake]     fmt::fmt
kwsp commented 2 months ago

Are you using the latest version of Kompute? This issue should be fixed already:

https://github.com/KomputeProject/kompute/blob/40f9adf62e270d679ce5c9a72b0fae01155a094d/CMakeLists.txt#L184-L192

In the else() branch, fmt should've been found.

axsaucedo commented 2 months ago

+1 this was indeed an issue but was resolved