Closed ThePseudo closed 1 month ago
Looks good - only thing would be to add a test, and we can then merge. You can add this on the Tensor test file.
Just following up, do you think you would be able to have a look with a short test @ThePseudo ?
Sorry for the delay, at some point stuff happened and I lost track of a few things (one being this). I created a short test, which could be expanded upon, but is basically "inspired" by the other test already present. I hope this works!
No worries @ThePseudo, thank you for following up - running test suite
@ThePseudo it seems tests failing, did you run locally?
The terrible thing is that I am not really an expert in the Google test suite... but I found that the tests were failing for a good reason, apparently, and it is building. Which is strange, since "it worked on my machine", but let's try this out
Thank you @ThePseudo - remaining commment on a small docstring change required
It should be done now, but tell me if the format is not correct (I took inspiration from previous docstrings)
Added extra suggestion as it needs to follow the same format as rest of docstrings
Thank you @ThePseudo - signed commit required, and we should be able to wrap it up :)
Thank you @ThePseudo - signed commit required, and we should be able to wrap it up :)
Forgot it, now added! :D
Thanks!
Added methods reserve() and constructor for Tensor and TensorT