search

KonPfeifer / prj-rev-bwfs-tea-cozy

0 stars 0 forks source link

Summary. #6

Open kalverra opened 7 years ago

kalverra commented 7 years ago

Grade: Needs Improvement

Summary: Your overall code organization is well done through indentation and spaces, though comments could help, the code is well done on its own. However, quite a few issues pop up in your organization of your backgrounds. You can either manipulate the backgrounds themselves to size them appropriately or manipulate the elements they occupy.. make sure to check out my link. Also when using flexbox, you need to utilize it well in order to actually take advantage of its properties.

Once your resizing kinks are worked out, make sure to try adding some personal flair to the site. You can check out this site to get some ideas of modern web design patterns. http://www.webdesign-inspiration.com/web-designs/style/modern

KonPfeifer commented 7 years ago

Thanks for your input. To background sizing: The repeat issue was a bad mistake of mine, I seem to have just overlooked it. To the 2nd background: The picture of the redline won't really work with the specs, in my experience. The image seems to be larger than the specified 500px, or the background ratio won't work, as the positioning of the boxes will hide a larger part of the background then the redline. At least that was my experience while writing the code and again while trying to fix it right now...