KonSola5 / HephaestusPlus

An addon for Hephaestus.
MIT License
3 stars 2 forks source link

CarmotShieldMixin has @Debug annotation in production jar #14

Open unilock opened 4 months ago

unilock commented 4 months ago

Describe the bug

This mod's CarmotShieldMixin class has the @Debug mixin annotation applied, meaning the mixin processor is set to export its target class every time the game starts. This is not necessary in a production environment. Ideally the annotation can simply be removed.

https://github.com/KonSola5/HephaestusPlus/blob/b7d10ce23a7400810455542481ff469ea6111360/src/main/java/konsola5/hephaestusplus/mixin/CarmotShieldMixin.java#L20-L22

To Reproduce

  1. Install Fabric, Hephaestus, HephaestusPlus, Mythic Metals, etc.
  2. Start the game.
  3. The CarmotShield class is exported by the mixin processor to .minecraft/.mixin.out.

Expected behavior

That doesn't happen.

Screenshots

N/A

Crash log or game log (if applicable)

N/A

Mod List

Mod List: click to show
  • Fabric API
  • Hephaestus
  • HephaestusPlus
  • Mythic Metals
  • Alloy Forgery
  • owo-lib

Versions

Additional context

N/A

KonSola5 commented 4 months ago

Oops, will remove!

(This was added since at a time I couldn't get the -Dmixin.debug.export=true flag to work)