Add native build - Githubissues

KonaeAkira / raphael-rs

Crafting rotation optimizer / macro generator for Final Fantasy XIV

https://www.raphael-xiv.com/

Apache License 2.0

67 stars 14 forks source link

Add native build #71

Closed Human-Hamster closed 1 month ago

Human-Hamster commented 1 month ago

Resolves #68

Implement WASM and Native compatible builds
- Refactor Webworker to unified worker interface
- Native implementation on par with WASM
- Unify both WASM and native implementations under an adapter
Add build instructions for native

Caveats: Instead of changing the solver update behavior depending on build target, I implemented a hook into the existing implementation. This seems to have removed all speed improvements but should be more maintainable.

KonaeAkira commented 1 month ago

Also, you don't need to squash your PR commits. I will squash the entire PR when merging it ;)

KonaeAkira commented 1 month ago

This seems to have removed all speed improvements but should be more maintainable.

The channel's performance is not important, simply because there are very few messages being passed around, and the time spent interacting with the channel is negligible when compared to the time used by the solving algorithm.

Human-Hamster commented 1 month ago

Will do the multi-file solution, shouldn't be too difficult mostly refactoring. Will also update to work with the develop branch since SolverConfig is passed to the worker thread instead of a bool.

Will do this tomorrow night if I have the time.

Human-Hamster commented 1 month ago

Everything has been changed as requested. Let me know if there's anything else