Closed augenfrosch closed 3 weeks ago
I made the requested change and (hopefully) fixed the failing tests. One of the tests (test_item_name_44232_hq
) had to be rewritten since with the current implementation an item that is always a collectable will only include the collectable character at the end of it's name. To test the HQ functionality, I added a new test (test_item_name_44104_hq
) that replaces the role of the aforementioned test
Additionally, I implemented two of my proposed alterations that I would now consider a usability improvement:
Without these changes a user can not easily search for the same things possible in the current version of Raphael. Specifically, searches that included "(HQ)" at the end were not possible.
Nice work! Thank you for your contribution :)
Adds text icons for HQ items and collectables using the same Unicode characters Final Fantasy XIV uses. Additionally, improves the handling of pasted text copied from the game and changes
game_data::Item
to useAlwaysCollectable
instead ofIsCollectable
fromItem.csv
.Overview of the changes:
'\u{e03c}'
instead of "(HQ)" when displaying the name of HQ items'\u{e03d}'
to the end of the name of collectablesgame_data::Item
to useAlwaysCollectable
instead ofIsCollectable
fromItem.csv
.Caveats / Limitations caused by the current implementation:
Item.csv
which is potentially undesirable. Alternatively, you could pass an additional argument (can_be_collectable
) togame_data::get_item_name
Screenshot: