KonaeAkira / raphael-rs

Crafting rotation optimizer / macro generator for Final Fantasy XIV
https://www.raphael-xiv.com/
Apache License 2.0
67 stars 14 forks source link

Add text icons for HQ items and collectables #77

Closed augenfrosch closed 3 weeks ago

augenfrosch commented 3 weeks ago

Adds text icons for HQ items and collectables using the same Unicode characters Final Fantasy XIV uses. Additionally, improves the handling of pasted text copied from the game and changes game_data::Item to use AlwaysCollectable instead of IsCollectable from Item.csv.

Overview of the changes:

Caveats / Limitations caused by the current implementation:

Screenshot: image

augenfrosch commented 3 weeks ago

I made the requested change and (hopefully) fixed the failing tests. One of the tests (test_item_name_44232_hq) had to be rewritten since with the current implementation an item that is always a collectable will only include the collectable character at the end of it's name. To test the HQ functionality, I added a new test (test_item_name_44104_hq) that replaces the role of the aforementioned test

Additionally, I implemented two of my proposed alterations that I would now consider a usability improvement:

Without these changes a user can not easily search for the same things possible in the current version of Raphael. Specifically, searches that included "(HQ)" at the end were not possible.

KonaeAkira commented 3 weeks ago

Nice work! Thank you for your contribution :)