Konash / arabic-support-unity

This plugin allows you to use accurate and correct Arabic text in your game or 3D application. Supports Tashkeel and Hindu numbers. Supports C# and JavaScript. Supports 4 Persian Characters.
MIT License
220 stars 64 forks source link

"!" wasn't putted on the end line #19

Closed WhiteDambi closed 7 years ago

WhiteDambi commented 7 years ago

Hello, this is Stefan who sent the email yesterday. I did the test as your recommend that is using last version.

test text : البحث عن تحديات أكبر في دوريات أعلى!

test

copy output text and paste to NGUI label

test1

Sorry, I "totally" don't know Arabic at all, so I could not check whether result is correct or not But even i don't know, but i think "!" should be putted on the final sentence, am i correct ?

Konash commented 7 years ago

This is really weird. I copied and pasted your text and this was the result:

image

Do you think it have to do with the device default language? It shouldn't!

Try adding a space between the last word and the ! mark. will it do the same?

Konash commented 7 years ago

Are you still facing the issue? Can someone else test this?

darrencperry commented 7 years ago

Win10 - English default language - Unity 5.6.0f3

Works fine: image

darrencperry commented 7 years ago

@trident667 are you using TextMesh Pro?

edit: reread your post, using NGUI, never mind!

WhiteDambi commented 7 years ago

Win10- Republic of korea default language - Unity 5.6.3f1

It seems to be a default language problem.

Changing the default language from Unity works fine.

I don't use TextMesh Pro.

Konash commented 7 years ago

Does this mean we are good?

On Nov 3, 2017 1:06 AM, "trident667" notifications@github.com wrote:

Win10- Republic of korea default language - Unity 5.6.3f1

It seems to be a basic language problem.

Changing the default language from Unity works fine.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Konash/arabic-support-unity/issues/19#issuecomment-341623434, or mute the thread https://github.com/notifications/unsubscribe-auth/ALtBUkBmWR_F7ah3J88ozB-r5znTxQmnks5syp8_gaJpZM4QNt2I .

WhiteDambi commented 7 years ago

Sorry to late response. I'll try to find solution during this weekend. Then I'll ask you few qestions.

WhiteDambi commented 7 years ago

I am so sorry. my fault.. your code do not have bug.