search

KonduitAI / konduit-serving

Enterprise runtime for machine learning models
https://serving.konduit.ai/
Apache License 2.0
47 stars 15 forks source link

Support for SavedModels PB files in TensorFlowConfig #49

Open philip-khor opened 4 years ago

philip-khor commented 4 years ago

The SavedModels standard for saving models was introduced in TF2.0. Protobuffs created in TensorFlow 2.0 cannot currently be used with a TensorFlowConfig since version 2.0 of TensorFlow for Java is not released yet.

Using a protobuff created in TF2.0 will raise the following exception: 

org.nd4j.shade.protobuf.InvalidProtocolBufferException: While parsing a protocol message, the input ended unexpectedly in the middle of
a field.  This could mean either that the input has been truncated or that an embedded message misreported its own length.

ping @saudet

agibsonccc commented 4 years ago

Mind adding a zip file somewhere to allow us to reproduce?

philip-khor commented 4 years ago

https://drive.google.com/file/d/1X5M1yU8QH8e3E5VBNePqfAQeUunoFUlv/view?usp=sharing

maxpumperla commented 4 years ago

@philip-khor @agibsonccc shouldn't we rather flag this upstream in dl4j / tf import?

agibsonccc commented 4 years ago

@maxpumperla this actually isn't model import related. It's pure TF java embedded in konduit-serving related :)