Closed tao12345666333 closed 7 months ago
Ah, we didn't actually build the env/arg equivalence we have in the controller into the operator?
Yes. We have an issue for tracking https://github.com/Kong/gateway-operator/issues/19
We don't want to have to replicate every aspect of the application config in the chart, you should be able to expose a generic env or args list that lets you set them arbitrarily (most should be unset by default--we control the upstream defaults and should choose good defaults there). Something like the controllers section to set a subset of args shouldn't actually exist, but we're kinda stuck with that at the moment (or writing something similar to kong.env for args, which is annoying due to their lack of a key/value structure).
I agree with you. We need to make some adjustments, similar to https://github.com/Kong/charts/pull/1027#discussion_r1517732656
There are still many areas that need improvement, and I will continue to follow up on them in the future.
What this PR does / why we need it:
The first release of the KGO chart.
This is the only commit added compared to the
prepare-kgo-chart
branch. https://github.com/Kong/charts/commit/a77739315f096aba2d501769e732575952884136Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
This chart has been marked as a pre-release version. https://github.com/Kong/charts/pull/1031/files#diff-687b44a1f065c7497da04c3af622511715f75bbaaedd2ea617678b3f85ff6d88R14
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.