Kong / charts

Helm chart for Kong
Apache License 2.0
247 stars 477 forks source link

chore(RBAC) disable session conf secret if not set #1033

Closed rainest closed 6 months ago

rainest commented 6 months ago

What this PR does / why we need it:

Replace the default placeholder value for enterprise.rbac.session_conf_secret with an empty string.

Disable configuring a session conf envvar if session_conf_secret is not set.

From https://docs.konghq.com/gateway/changelog/#3600 and https://docs.konghq.com/gateway/3.6.x/kong-manager/auth/oidc/migrate/, Kong 3.6+ uses only KONG_ADMIN_GUI_AUTH_CONF when using OIDC for Manager.

Prior to 3.6, Kong required KONG_ADMIN_GUI_SESSION_CONF when using RBAC. The original chart design effectively required users set session_conf_secret as it would try to reference a nonexistent placeholder Secret name otherwise.

Special notes for your reviewer:

Waiting for confirmation from the reporter that we don't actually need anything else to handle 3.6 properly.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

gperanich commented 6 months ago

This should suffice, will make support for <3.6 and >3.6 much simpler