fix(ingress) disable duplicate CRD installation

Kong / charts

Helm chart for Kong

Apache License 2.0

237 stars 473 forks source link

fix(ingress) disable duplicate CRD installation #1052

Closed NissesSenap closed 2 months ago

NissesSenap commented 2 months ago

What this PR does / why we need it:

Remove

Which issue this PR fixes

fixes #1051

Special notes for your reviewer:

Checklist

[X] PR is based off the current tip of the main branch.
[X] Changes are documented under the "Unreleased" header in CHANGELOG.md
[X] New or modified sections of values.yaml are documented in the README.md
[X] Commits follow the Kong commit message guidelines

CLAassistant commented 2 months ago

All committers have signed the CLA.

NissesSenap commented 2 months ago

I don't think this will work, due to templates for CRD don't work in helm 3 if I understand it correctly https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds We would need to do skipCRDs on the subcharts, but that isn't possible https://github.com/helm/helm/issues/10540

The issue have popped up a number of times in helm, but no luck. So I'm unsure if there is any way around this. If anyone have a better idea on how to solve it please share.

NissesSenap commented 2 months ago

This won't change anything, so I will close this