Kong / charts

Helm chart for Kong
Apache License 2.0
237 stars 473 forks source link

feat(admission) add secret filter #1061

Closed rainest closed 2 months ago

rainest commented 2 months ago

What this PR does / why we need it:

Chart manifest component of https://github.com/Kong/kubernetes-ingress-controller/pull/5856

Removes the secrets entry from the existing webhook.

Adds an ingressController.admissionWebhook.filterSecrets boolean value. When true, it creates webhooks that accept only Secrets with known KIC-relevant labels. When false, it creates a webhook that accepts any (non-Helm) Secret.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

czeslavo commented 2 months ago

I've regenerated golden files using the latest version of chartsnap to reduce changes volume: eceadb9

Chartsnap in v0.3.0 changed the format of golden files from TOML to YAML and I adopted this format in https://github.com/Kong/charts/pull/1054. One mistake I made was to not enforce a local version to always match the one defined as desired. This should fix it for the future: https://github.com/Kong/charts/pull/1064.