feat(kgo): add ability to specify probes - Githubissues

Kong / charts

Helm chart for Kong

Apache License 2.0

247 stars 477 forks source link

feat(kgo): add ability to specify probes #1062

Closed pmalek closed 5 months ago

pmalek commented 5 months ago

What this PR does / why we need it:

Add ability to specify readinessProbe and livenessProbe for KGO Pods.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[ ] Changes are documented under the "Unreleased" header in CHANGELOG.md
[ ] New or modified sections of values.yaml are documented in the README.md
[ ] Commits follow the Kong commit message guidelines

pmalek commented 5 months ago

I guess we just don't have a changelog for this chart at all yet? We should probably add that.

https://github.com/Kong/charts/pull/1063

FWIW this will be affected by the same issue that affects the kong chart, where you can't add checks that aren't httpGet due to the way Helm handles YAML merges. That probably doesn't really matter as you shouldn't need to change that outside of removing the checks entirely for special debug reasons (usually running Delve, which prevents the endpoints from responding when paused).

ACK