Kong / charts

Helm chart for Kong
Apache License 2.0
242 stars 474 forks source link

IngressClass template doesn't respect env vars #1100

Open joran-fonjallaz opened 1 month ago

joran-fonjallaz commented 1 month ago

the Kong Ingress Controller offers many flags to configure the executable as defined here https://docs.konghq.com/kubernetes-ingress-controller/latest/reference/cli-arguments/

However, when running Kong Ingress Controller only with Gateway CRDs (GatewayClass, HTTPRoute, etc.), it can be desired to turn off the Ingress capabilities (think for example running and Kong for Ingress resources next to a Kong for Gateway resources during a migration).

However, the IngressClass resource here https://github.com/Kong/charts/blob/main/charts/kong/templates/ingress-class.yaml#L22 doesn't respect the flags below (or the env var)

==> none of the flags above disable the creation of the ingressClass, nor changes its name.

I would expect that setting --enable-controller-ingress-class-networkingv1 to false would not create the resource. I would expect that setting --ingress-class to foo would name the IngressClass resource foo