Kong / charts

Helm chart for Kong
Apache License 2.0
245 stars 475 forks source link

Apply .address equally across listens #881

Closed rainest closed 1 year ago

rainest commented 1 year ago

What this PR does / why we need it:

Honors the .address across listens. Some of these previously had special cases that forced their address to a hardcoded value.

Creates a new release.

Which issue this PR fixes

IPv6 support with hardcoded v4 addresses was difficult.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

rainest commented 1 year ago

With this PR:

$ helm template ana /tmp/symkong -f /tmp/v6.yaml --set proxy.address=[::] --set admin.address=[::1] --set status.address=[::] --set cluster.address=[::] --set ingressController.admissionWebhook.address=[::] | grep -A1 _LISTEN                                                                                                                                                                                  

        - name: KONG_ADMIN_LISTEN
          value: "[::1]:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "[::]:9000"
--
        - name: CONTROLLER_ADMISSION_WEBHOOK_LISTEN
          value: "[::]:8080"
--
        - name: KONG_ADMIN_LISTEN
          value: "[::1]:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "[::]:9000"

versus

$ helm template ana kong/kong -f /tmp/v6.yaml --set proxy.address=[::] --set admin.address=[::1] --set status.address=[::] --set cluster.address=[::] --set ingressController.admissionWebhook.address=[::] | grep -A1 _LISTEN                   
        - name: KONG_ADMIN_LISTEN
          value: "127.0.0.1:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "0.0.0.0:9000"
--
        - name: CONTROLLER_ADMISSION_WEBHOOK_LISTEN
          value: "0.0.0.0:8080"
--
        - name: KONG_ADMIN_LISTEN
          value: "127.0.0.1:8444 http2 ssl"
        - name: KONG_CLUSTER_LISTEN
          value: "off"
--
        - name: KONG_PROXY_LISTEN
          value: "[::]:8000, [::]:8443 http2 ssl"
--
        - name: KONG_STATUS_LISTEN
          value: "[::]:8100"
        - name: KONG_STREAM_LISTEN
          value: "0.0.0.0:9000"