Kong / charts

Helm chart for Kong
Apache License 2.0
248 stars 480 forks source link

feat(crd) add a CRD-checking system #895

Closed rainest closed 3 months ago

rainest commented 1 year ago

What this PR does / why we need it:

Add a CRD version index and failure condition when the installed CRDs are below the requested level. On failure, chart actions will print a message with the update command.

One of the options from https://github.com/Kong/charts/issues/890

Special notes for your reviewer:

The CRD annotation this check relies on does not exist yet. We can add it with additional configuration in KIC's config/crd/kustomization.yaml:

commonAnnotations:
  konghq.com/kic-crd-release: 2.9.0

Draft pending additional testing and possibly some mechanism for less manual version maintenance.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

rainest commented 3 months ago

Closed as part of my issue/PR handover. Was abandoned for lack of priority, but code's available for reference in the event we want to try a NOTES.txt CRD alert in the future.