This is a bit explicit way, but I couldn't come up with anything else that could allow us to pick a controller.ingressController.image value and somehow inject it into the other subchart.
Example values.yaml that demonstrates how this could be used in Konnect installation instructions:
This should be safe, as when gateway.deployment.kong.alignWithControllerVersion will be left empty, the old default will be used, so we're not breaking anything. It would be opt-in and instructions would have to be updated to use that.
An obvious drawback is that it won't work with just helm install kong kong/ingress. Installation command would have to be more complex, i.e.:
helm install kong kong/ingress --set gateway.deployment.kong.alignWithControllerVersion=3.0 --set controller.ingressController.image.tag=3.0
So it's on a similar level of user-friendliness as just telling the user to set the router flavor explicitly if they're using KIC >= 3.0:
helm install kong kong/ingress --set gateway.env.router_flavor=expressions
What this PR does / why we need it:
It's an attempt to provide a workaround for the inability to propagate values between two subcharts (
gateway
andcontroller
) inkong/ingress
chart.Branches off https://github.com/Kong/charts/pull/935.
This is a bit explicit way, but I couldn't come up with anything else that could allow us to pick a
controller.ingressController.image
value and somehow inject it into the other subchart.Example
values.yaml
that demonstrates how this could be used in Konnect installation instructions:This should be safe, as when
gateway.deployment.kong.alignWithControllerVersion
will be left empty, the old default will be used, so we're not breaking anything. It would be opt-in and instructions would have to be updated to use that.An obvious drawback is that it won't work with just
helm install kong kong/ingress
. Installation command would have to be more complex, i.e.:So it's on a similar level of user-friendliness as just telling the user to set the router flavor explicitly if they're using KIC >= 3.0: