Kong / charts

Helm chart for Kong
Apache License 2.0
243 stars 475 forks source link

feat: make expressions router default #939

Closed czeslavo closed 5 months ago

czeslavo commented 10 months ago

What this PR does / why we need it:

Sets the expression router as default in kong/kong. Adds validations that ensure that:

to both kong/kong and kong/ingress charts.

Validations will output instructions on how to fix the issue if it is encountered.

It also changes the way we refer to kong/kong in kong/ingress's Chart.yaml: instead of using the repository URL that forces us to bump charts in two steps, use file:// to make it possible in one step.

Which issue this PR fixes

Should solve https://github.com/Kong/kubernetes-ingress-controller/issues/5129.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

czeslavo commented 10 months ago

Per @mheap, I'm labeling this with HOLD/DO NOT MERGE until Konnect is compatible with expressions.

pmalek commented 9 months ago

Could potentially be put in kong v3 milestone