fix(serviceMonitor) set 30s as default interval - Githubissues

Kong / charts

Helm chart for Kong

Apache License 2.0

243 stars 475 forks source link

fix(serviceMonitor) set 30s as default interval #941

Closed dweber019 closed 10 months ago

dweber019 commented 10 months ago

What this PR does / why we need it:

The default interval should be 30s to support the rate of 1m of the official Kong Grafana dashboard. Dashboard https://grafana.com/grafana/dashboards/7424-kong-official/

Which issue this PR fixes

N/A

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[x] Changes are documented under the "Unreleased" header in CHANGELOG.md
[x] New or modified sections of values.yaml are documented in the README.md
[x] Commits follow the Kong commit message guidelines

dweber019 commented 10 months ago

Nice catch. We have indeed changed this in our Prometheus operator, so the issue was cased by our setup and not this chart or the Grafana dashboard.

Closing this PR. Thx