Kong / charts

Helm chart for Kong
Apache License 2.0
243 stars 475 forks source link

feat: allow hostname override #943

Closed nicklasfrahm closed 10 months ago

nicklasfrahm commented 10 months ago

What this PR does / why we need it:

Our API management uses Kong and we have dataplane deployments in multiple regions. At the moment our lovely uber-API guy REMOG creates a hardcopy of the helm chart, which drastically increases maintenance effort on his side.

This is the only feature he is missing, so the platform guy (me) is helping out.

Checklist

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

remogvestas commented 10 months ago

we use the hostname variable to have a saying hostname in the response of the /clustering/data-planes endpoint, like:

data: [ [-] { [-] config_hash: b4d10b38ea9c510b0d5590c2c04a4fdb hostname: dataplane-git-weu id: 010be8cf-c5f9-42ea-b94f-76a3a05bda2c ip: xx.xx.xx.xx last_seen: 1700132083 sync_status: normal ttl: 1209581 version: 3.1.1.1

  so we easily can check the status of all dataplanes across all regions and instances