Kong / charts

Helm chart for Kong
Apache License 2.0
248 stars 480 forks source link

Update quickstart example yaml #944

Open akoshok1 opened 11 months ago

akoshok1 commented 11 months ago

When trying https://raw.githubusercontent.com/Kong/charts/main/charts/kong/example-values/doc-examples/quickstart-enterprise-licensed-aio.yaml

We get:

May I suggest we: 1-alter ingressController.ingressClass to kong 2-For consistency, also set admin.ingressClassName to kong

randmonkey commented 11 months ago

The ingress classes becomes inconsistent after https://github.com/Kong/charts/commit/da4889ffde4792cb44ace9e81bfc525313c700c3. We should use the same ingress class: all use default (the original value) or all use kong.

akoshok1 commented 11 months ago

Perhaps kong is a better choice, as there is a good chance default may already be used in clusters we install to.

rainest commented 11 months ago

Per chat, @mheap said he wanted to review this guide overall as part of fixing this, so assigning to him.

akoshok1 commented 11 months ago

While at it, let us please remove the two hostport settings which cause issues in EKS w/ Fargate and we do not use in other examples.