Kong / charts

Helm chart for Kong
Apache License 2.0
242 stars 474 forks source link

chore(admission) remove GWAPI types from webhook #956

Closed rainest closed 8 months ago

rainest commented 9 months ago

What this PR does / why we need it:

Remove GWAPI types from the webhook. We plan to remove these in the controller (https://github.com/Kong/kubernetes-ingress-controller/issues/5197) and there's no clear need to continue using them. Since they currently cause a version compatibility issue (https://github.com/Kong/charts/pull/954) I'd like to just remove them preemptively. KIC hasn't changed yet, but those changes aren't a hard prereq to removing the webhook config.

Held pending confirmation that we don't need these.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

programmer04 commented 8 months ago

For HTTPRoute regexes are validated with webhook see

rainest commented 8 months ago

Forgot to close this after merging #954.