Kong / charts

Helm chart for Kong
Apache License 2.0
242 stars 474 forks source link

kong: only set `clusterIP` when `type` is `ClusterIP` #961

Closed pmalek closed 8 months ago

pmalek commented 8 months ago

What this PR does / why we need it:

Only set clusterIP when type is ClusterIP. This will allow using e.g. NodePort in ingress chart.

Which issue this PR fixes

Special notes for your reviewer:

After this gets merged we can add a test case to ingress chart like so:

controller:
  ingressController:
    env:
      anonymous_reports: "false"
    enabled: true
    image:
      repository: kong/kubernetes-ingress-controller

    gatewayDiscovery:
      enabled: true
    adminApi:
      tls:
        client:
          enabled: true

gateway:
  env:
    anonymous_reports: "off"
  admin:
    type: NodePort
  readinessProbe:
    initialDelaySeconds: 1
    timeoutSeconds: 1
    periodSeconds: 1

Checklist

pmalek commented 8 months ago

Ah yes, null does work 🤦 Approved #962