Closed pmalek closed 8 months ago
Only set clusterIP when type is ClusterIP. This will allow using e.g. NodePort in ingress chart.
clusterIP
type
ClusterIP
NodePort
ingress
After this gets merged we can add a test case to ingress chart like so:
controller: ingressController: env: anonymous_reports: "false" enabled: true image: repository: kong/kubernetes-ingress-controller gatewayDiscovery: enabled: true adminApi: tls: client: enabled: true gateway: env: anonymous_reports: "off" admin: type: NodePort readinessProbe: initialDelaySeconds: 1 timeoutSeconds: 1 periodSeconds: 1
main
Ah yes, null does work 🤦 Approved #962
null
What this PR does / why we need it:
Only set
clusterIP
whentype
isClusterIP
. This will allow using e.g.NodePort
iningress
chart.Which issue this PR fixes
Special notes for your reviewer:
After this gets merged we can add a test case to
ingress
chart like so:Checklist
main
branch.