Closed czeslavo closed 8 months ago
@pmalek I changed the kong/kong
repository from https://
to file://
deliberately to allow bumping both charts in a single commit. Is this something that we'd like to avoid? As I understand, we always want to make them be in sync - that enables us to make it happen without an additional PR to bump kong/ingress
dependencies separately.
@pmalek I changed the
kong/kong
repository fromhttps://
tofile://
deliberately to allow bumping both charts in a single commit. Is this something that we'd like to avoid? As I understand, we always want to make them be in sync - that enables us to make it happen without an additional PR to bumpkong/ingress
dependencies separately.
I do recall there was a discussion about this at some point. Perhaps @programmer04 or @rainest can chip in. I believe one of the arguments against it was that we wouldn't explicitly know which version are we using at particular point in time (it would be the current version during the helm dependency update invocation). Now we don't have that solve either, we only have the minimal version and we rebuild the deps on release (this is similar to what you proposed in this PR).
I'm not sure what would be the best approach for this 🤔
👍 Alright, to not block this PR on this, I backed off to only kong/kong
changes and will proceed with a separate PR bumping this in kong/ingress
.
What this PR does / why we need it:
Adds
KongServiceFacade
RBAC rules and releaseskong/kong
2.33.0. ~both charts (changed theingress
'sChart.yaml
to refer tokong
byfile://
instead ofhttps://
which allows bumping both charts in a single commit).~Which issue this PR fixes
Part of https://github.com/Kong/kubernetes-ingress-controller/issues/5152.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.