Kong / charts

Helm chart for Kong
Apache License 2.0
242 stars 474 forks source link

migrations-post-upgrade.yaml fails when using affinity #967

Closed boatmisser closed 8 months ago

boatmisser commented 8 months ago

Chart version: 2.33.0

Since the addition of affinity to the migration templates (see https://github.com/Kong/charts/pull/946/files) The template generation fails with:

Error: YAML parse error on kong/templates/migrations-post-upgrade.yaml: error converting YAML to JSON: yaml: line 226: mapping values are not allowed in this context
helm.go:84: [debug] error converting YAML to JSON: yaml: line 226: mapping values are not allowed in this context
YAML parse error on kong/templates/migrations-post-upgrade.yaml
helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort
        helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146
helm.sh/helm/v3/pkg/releaseutil.SortManifests
        helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106
helm.sh/helm/v3/pkg/action.(*Configuration).renderResources
        helm.sh/helm/v3/pkg/action/action.go:170
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
        helm.sh/helm/v3/pkg/action/install.go:284
main.runInstall
        helm.sh/helm/v3/cmd/helm/install.go:286
main.newUpgradeCmd.func2
        helm.sh/helm/v3/cmd/helm/upgrade.go:130
github.com/spf13/cobra.(*Command).execute
        github.com/spf13/cobra@v1.6.1/command.go:916
github.com/spf13/cobra.(*Command).ExecuteC
        github.com/spf13/cobra@v1.6.1/command.go:1044
github.com/spf13/cobra.(*Command).Execute
        github.com/spf13/cobra@v1.6.1/command.go:968
main.main
        helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
        runtime/proc.go:250
runtime.goexit
        runtime/asm_arm64.s:1172

From looking at the change it seems that the template mistakenly uses indent instead of nindent; I came to this assumption as all other template commands in the migration templates use nindent while the new affinity is the only one that does not.