tests: introduce golden tests in kong chart using chartsnap - Githubissues

Kong / charts

Helm chart for Kong

Apache License 2.0

242 stars 474 forks source link

tests: introduce golden tests in kong chart using chartsnap #978

Closed czeslavo closed 7 months ago

czeslavo commented 8 months ago

What this PR does / why we need it:

An alternative to https://github.com/Kong/charts/pull/953 using the existing helm-chartsnap helm plugin that became useful for us thanks to its maintainer @jlandowner quickly fixing an issue that was a blocker for us: https://github.com/jlandowner/helm-chartsnap/issues/30.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[x] Changes are documented under the "Unreleased" header in CHANGELOG.md
[x] New or modified sections of values.yaml are documented in the README.md
[x] Commits follow the Kong commit message guidelines

czeslavo commented 7 months ago

The test.golden makefile target was printing the command itself as there was no @ before it to suppress the output. With that added, it should no longer misguide with the "Golden tests have failed" in the positive scenario. Also, the newline should work now (it's been working for me without the changes, but apparently that might be an issue in some shells 🤷): 0dccf83