Closed czeslavo closed 7 months ago
The test.golden
makefile target was printing the command itself as there was no @
before it to suppress the output. With that added, it should no longer misguide with the "Golden tests have failed" in the positive scenario. Also, the newline should work now (it's been working for me without the changes, but apparently that might be an issue in some shells 🤷): 0dccf83
What this PR does / why we need it:
An alternative to https://github.com/Kong/charts/pull/953 using the existing
helm-chartsnap
helm plugin that became useful for us thanks to its maintainer @jlandowner quickly fixing an issue that was a blocker for us: https://github.com/jlandowner/helm-chartsnap/issues/30.Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.