Kong / charts

Helm chart for Kong
Apache License 2.0
242 stars 474 forks source link

feat(env) add support for envFrom #987

Closed rainest closed 7 months ago

rainest commented 7 months ago

What this PR does / why we need it:

Add envFrom and ingressController.envFrom values. These populate the standard container envFrom field, which contains a list of ConfigMap or Secret refs. Keys and values from the referenced resources are set as environment variables in the containers.

Which issue this PR fixes

Aha idea KIC-I-52 from @felderi

Special notes for your reviewer:

The root-level envFrom violates the modern rule about placing config for the Deployment under the deployment key. I put it there for consistency with the existing env and customEnv values.

This uses the envFrom key to populate envFrom in the Deployment Kong container as well as the init containers and migrations containers. Several of these only appear in DB mode. test2-values uses Postgres and the the controller, so it hits every use of this value in templates.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]