Adding more template rendering to labels and annotations

Kong / charts

Helm chart for Kong

Apache License 2.0

242 stars 474 forks source link

Adding more template rendering to labels and annotations #999

Closed ANGkeith closed 6 months ago

ANGkeith commented 6 months ago

What this PR does / why we need it:

This PR is a continuation of https://github.com/Kong/charts/pull/814 to add more template rendering support

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] PR is based off the current tip of the main branch.
[x] Changes are documented under the "Unreleased" header in CHANGELOG.md
[x] Commits follow the Kong commit message guidelines

CLAassistant commented 6 months ago

All committers have signed the CLA.

rainest commented 6 months ago

Templates in values should not be added piecemeal and we should not have added #814 without broader review of how we handle template injection across the chart. Please submit this as a feature request issue instead of a PR.