Kong / docs.konghq.com

🦍 Source code for docs.konghq.com website.
https://docs.konghq.com
MIT License
199 stars 596 forks source link

Invalid JSON in LDAP docs #3141

Closed laughingbiscuit closed 3 years ago

laughingbiscuit commented 3 years ago

What part of the site needs attention?

https://docs.konghq.com/enterprise/2.4.x/kong-manager/authentication/ldap/

Summary

This JSON is not valid

admin_gui_auth = ldap-auth-advanced
enforce_rbac = on
admin_gui_session_conf = { "secret":"set-your-string-here" }
admin_gui_auth_conf = {                                       \
    "anonymous":"",                                           \
    "attribute":"<ENTER_YOUR_ATTRIBUTE_HERE>",                \
    "bind_dn":"<ENTER_YOUR_BIND_DN_HERE>",                    \
    "base_dn":"<ENTER_YOUR_BASE_DN_HERE>",                    \
    "cache_ttl": 2,                                           \
    "header_type":"Basic",                                    \
    "keepalive":60000,                                        \
    "ldap_host":"<ENTER_YOUR_LDAP_HOST_HERE>",                \
    "ldap_password":"<ENTER_YOUR_LDAP_PASSWORD_HERE>",        \
    "ldap_port":389,                                          \
    "start_tls":false,                                        \
    "timeout":10000,                                          \
    "verify_ldap_host":true                                   \
    "consumer_by":["username", "custom_id"],                  \
}

as the last two properties have incorrect ,s

Steps To Reproduce

n/a

lena-larionova commented 3 years ago

Corrected in https://github.com/Kong/docs.konghq.com/pull/3142.