Kong / docs.konghq.com

🦍 Source code for docs.konghq.com website.
https://docs.konghq.com
MIT License
195 stars 589 forks source link

guide states adding a plugin to config, that's already added #73

Closed ahmadnassri closed 9 years ago

ahmadnassri commented 9 years ago

guide suggests adding a plugin: Add keyauth under the plugins_available property in your Kong instance configuration file

however, it seems all plugins are already added and enabled by default.

thibaultcha commented 9 years ago

It's adding a plugin on an API, not on Kong.

ahmadnassri commented 9 years ago

that's not what the text suggests.

thibaultcha commented 9 years ago

Because for now all of them are enabled by default, might not be the case when we have a proper architecture. Otherwise idk, didn't write this.

thibaultcha commented 9 years ago

And I think it's really fine, it makes people discover this property and know what it is used for.

nijikokun commented 9 years ago

The original text stated this, so I kept it, even though they are enabled by default the text allows you to understand where you will place third-party plugins or plugins that are not enabled by default should you come to a point where the plugin is not being invoked or ran at all.

Otherwise, you would never know this was a required step.

ahmadnassri commented 9 years ago

yeah, I don't think its a "problem" per say ... perhaps an adjustment of the text, an inexperienced user would potentially be confused to why the instructions are guiding him/her to do something that's already done ...

nijikokun commented 9 years ago
Add keyauth ... should it not already exist

Would this satisfy your requirements?

ahmadnassri commented 9 years ago

:+1: