Kong / docs.konghq.com

🦍 Source code for docs.konghq.com website.
https://docs.konghq.com
MIT License
193 stars 578 forks source link

Switch to mise for managing Ruby/Node versions #7592

Open mheap opened 2 days ago

mheap commented 2 days ago

Description

Switch from rbenv to mise for tool installs in the installation instructions as it's easier to use + also supports node

Testing instructions

Preview link: N/A

Checklist

netlify[bot] commented 2 days ago

Deploy Preview for kongdocs ready!

Name Link
Latest commit b2c9a98a5f27d26acb421bb3782d232fdcad4c4b
Latest deploy log https://app.netlify.com/sites/kongdocs/deploys/667ecabd8beb7900082bd194
Deploy Preview https://deploy-preview-7592--kongdocs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
9 paths audited
Performance: 92 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 98 (🟢 up 8 from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Guaris commented 1 day ago

@mheap Without rbenv how do I address this error?

angel$ mise install
mise all runtimes are installed

Then

angel$ make install
akefile:10: *** ruby "3.3.3" is required. Found "ruby 2.6.10p210 (2022-04-12 revision 67958) [universal.x86_64-darwin22]". Run `rbenv install "3.3.3"`.  Stop.
mheap commented 1 day ago

@Guaris Did you add the mise activate line to your zshrc?

fabianrbz commented 2 hours ago

@Guaris try removing the rbenv bits from your .zshrc if you have any.