Kong / galileo-agent-node

Node.js agent for Galileo - API Analytics
https://getgalileo.io
MIT License
9 stars 4 forks source link

content.text should never be `null` #11

Closed kennethklee closed 9 years ago

kennethklee commented 9 years ago

Agent always sends request.content.text and response.content.text. They should be omitted if text doesn't exist.

ahmadnassri commented 9 years ago

no, this is wrong. current behaviour is correct.

SGrondin commented 9 years ago

As discussed with Ahmad previously, this is how it works:

There is never any null. ever. ever. ever.

ever.

kennethklee commented 9 years ago

Just discussed with Ahmad. Null means the agent failed to process the body.

SGrondin commented 9 years ago

I don't understand how it could fail to base64-encode a string in the first place, but ok. It just seems like a hack to me.