search

Kong / galileo-agent-node

Node.js agent for Galileo - API Analytics
https://getgalileo.io
MIT License
9 stars 4 forks source link

clientIpAddress always last seen client IP #14

Open kennethklee opened 9 years ago

kennethklee commented 9 years ago

The batches always send the last seen client IP address.

https://github.com/Mashape/analytics-agent-node/blob/23b96751c290a7ca4dea688080ae8cf248c514ff/lib/index.js#L130

Since we only send 1 ALF, and its at the root, the clientIPaddress keeps changing when requests come from multiple user IPs.

When the agent flushes to socket, the last known clientIP address is sent. All the rest are lost.

kennethklee commented 9 years ago

On second look. it seems we don't even send clientIPAddress.

ahmadnassri commented 9 years ago

correct behaviour: agent should group/batch by clientIPAddress

ahmadnassri commented 9 years ago

@kennethklee if you can confirm clientIPAddress is not working open a new ticket with steps to re-produce, keep this one for the grouping discussion

ahmadnassri commented 8 years ago

@kennethklee ping

kennethklee commented 8 years ago

Let's see if I can reproduce...