refactored out queue and added timeout

Kong / galileo-agent-node

Node.js agent for Galileo - API Analytics

https://getgalileo.io

MIT License

9 stars 4 forks source link

refactored out queue and added timeout #16

Closed kennethklee closed 9 years ago

kennethklee commented 9 years ago

Changes:

Refactored out queue
Added option queueTimeout for flush timeout
Added timeout flushing and unit test

ahmadnassri commented 9 years ago

tests are failing

kennethklee commented 9 years ago

Should also fix #13

kennethklee commented 9 years ago

@ahmadnassri maybe you should fix master tests first...

ahmadnassri commented 9 years ago

can you separate this PR into multiple ones, start with the queue abstraction, thats fine as is, then after merge lets look at the timeout functionality, as it is now, they are both mixed together, but shouldn't be for this change.

kennethklee commented 9 years ago

i'll see what i can do separating the refactor and the timer into separate PRs

kennethklee commented 9 years ago

See https://github.com/Mashape/analytics-agent-node/pull/17 for refactor PR. The timer logic depends on the refactor.

kennethklee commented 9 years ago

Separated refactor logic in PR https://github.com/Mashape/analytics-agent-node/pull/17.

Timer logic was still under discussion.