GatewayClass finalizer addition - Githubissues

Kong / gateway-operator

Kubernetes Operator for Kong Gateways

Apache License 2.0

42 stars 9 forks source link

GatewayClass finalizer addition #192

Open mlavacca opened 1 year ago

mlavacca commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Problem Statement

According to the Gateway API documentation:

// Whenever one or more Gateways are using a GatewayClass, implementations MUST
// add the `gateway-exists-finalizer.gateway.networking.k8s.io` finalizer on the
// associated GatewayClass. This ensures that a GatewayClass associated with a
// Gateway is not deleted while in use.

No finalizer is currently added to the GatewayClass when a Gateway using it is provisioned.

Proposed Solution

Every time a Gateway using a valid GatewayClass is detected, the finalizer gateway-exists-finalizer.gateway.networking.k8s.io is added to the GatewayClass
Every time a GatewayClass is deleted, all the Gateways using it should be deleted before the finalizer removal.

Additional information

No response

Acceptance Criteria

[ ] Every time a Gateway using a valid GatewayClass is detected, the finalizer gateway-exists-finalizer.gateway.networking.k8s.io should be added to the GatewayClass.
[ ] Every time a GatewayClass is deleted, all the Gateways using it should be deleted before the finalizer removal.
[ ] A new integration test should verify that whenever a GatewayClass is deleted, all the Gateways using it are deleted before the finalizer removal.

mlavacca commented 1 year ago

This is under discussion upstream: https://github.com/kubernetes-sigs/gateway-api/issues/1411 Blocking it until it'll be resolved there.

mlavacca commented 3 months ago

This is not blocked anymore, as upstream the decision was to loosen the requirement from MUST to SHOULD.