Open shaneutt opened 1 year ago
Are orders within same type (loadbalancer IPs, cluster IPs) defined here? LoadBalancer
services could have multiple ingress addresses, and a service can have 2 cluster IPs if dualstack is supported.
Are orders within same type (loadbalancer IPs, cluster IPs) defined here?
LoadBalancer
services could have multiple ingress addresses, and a service can have 2 cluster IPs if dualstack is supported.
This was meant to encompass the situation where there are multiple LoadBalancer
ips, yes. As for dual stack that one's a bit trickier since it gets so little use, but I think if you're up for it you could do that here as well.
Problem Statement
For the purposes of clean
kubectl get gateways
output we're sorting addresses forGateways
based on whether or not they areLoadBalancer
addresses (IPs or Hostnames). In practice most situations will only ever have aClusterIP
and aLoadBalancer
IP, so this worked during the POC/pre-alpha stage to get the basics working but in the future when we have more than 2 addresses forGateways
this is not a consistent sort, AND we need to make a decision whether hostname or IP addresses should be prioritized.Proposed Solution
Gateway
status addresses consistent by introducing address type and address value sortinghostname
orip
addresses should have the highest priority, for the purposes ofkubectl get gateways
quick view outputRelated Issues
Not necessarily a blocker but it might be good to take care of this one first:
Acceptance Criteria
Service
has more than 2 addresses, address sorting is consistent so that I'm not getting extra reconciles