Kong / go-database-reconciler

Apache License 2.0
5 stars 3 forks source link

Fix: Expression route handling fix for Konnect and < v3.7.0 #118

Closed Prashansa-K closed 2 months ago

Prashansa-K commented 2 months ago

Summary

v3.7.0 added changes to allow traditional route fields with expression routes, thus making expression router a superset of traditional router. Ref: https://github.com/Kong/kong/pull/12667 Thus, keys like regex_priority are not supported in versions lesser than 3.7.0.

Added a gating logic in state builder for the necessary changes and fixed tests. Fix #1250

Full changelog

Issues resolved

Fix #1250

Documentation

Testing

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.35%. Comparing base (e7e4f68) to head (3f999c9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ========================================== + Coverage 41.23% 41.35% +0.12% ========================================== Files 75 75 Lines 10892 10895 +3 ========================================== + Hits 4491 4506 +15 + Misses 5937 5925 -12 Partials 464 464 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.